Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fwupd: 1.9.24 -> 1.9.25 #344392

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fwupd: 1.9.24 -> 1.9.25 #344392

merged 1 commit into from
Sep 25, 2024

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Sep 25, 2024 •
edited
Loading

Description of changes

Changelog: https://github.com/fwupd/fwupd/releases/tag/1.9.25

cc @r-vdp

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@r-vdp
Copy link
Contributor

r-vdp commented Sep 25, 2024

Result of nixpkgs-review pr 344392 run on x86_64-linux 1

27 packages built:
  • fwupd
  • fwupd.debug
  • fwupd.dev
  • fwupd.devdoc
  • fwupd.installedTests
  • fwupd.lib
  • fwupd.man
  • gnome-firmware
  • gnome-software
  • kdePackages.discover
  • kdePackages.discover.debug
  • kdePackages.discover.dev
  • kdePackages.discover.devtools
  • libsForQt5.discover
  • libsForQt5.kinfocenter
  • pantheon.elementary-greeter
  • pantheon.elementary-onboarding
  • pantheon.elementary-settings-daemon
  • pantheon.switchboard-plug-about
  • pantheon.switchboard-plug-pantheon-shell
  • pantheon.switchboard-plug-power
  • pantheon.switchboard-plug-security-privacy
  • pantheon.switchboard-with-plugs
  • pantheon.wingpanel-applications-menu
  • pantheon.wingpanel-indicator-power
  • pantheon.wingpanel-quick-settings
  • pantheon.wingpanel-with-indicators

r-vdp
r-vdp approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@r-vdp r-vdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 344392

x86_64-linux

✅ 27 packages built:
  • fwupd
  • fwupd.debug
  • fwupd.dev
  • fwupd.devdoc
  • fwupd.installedTests
  • fwupd.lib
  • fwupd.man
  • gnome-firmware
  • gnome-software
  • kdePackages.discover
  • kdePackages.discover.debug
  • kdePackages.discover.dev
  • kdePackages.discover.devtools
  • libsForQt5.discover
  • libsForQt5.kinfocenter
  • pantheon.elementary-greeter
  • pantheon.elementary-onboarding
  • pantheon.elementary-settings-daemon
  • pantheon.switchboard-plug-about
  • pantheon.switchboard-plug-pantheon-shell
  • pantheon.switchboard-plug-power
  • pantheon.switchboard-plug-security-privacy
  • pantheon.switchboard-with-plugs
  • pantheon.wingpanel-applications-menu
  • pantheon.wingpanel-indicator-power
  • pantheon.wingpanel-quick-settings
  • pantheon.wingpanel-with-indicators

aarch64-linux

✅ 26 packages built:
  • fwupd
  • fwupd.debug
  • fwupd.dev
  • fwupd.devdoc
  • fwupd.installedTests
  • fwupd.lib
  • fwupd.man
  • gnome-firmware
  • kdePackages.discover
  • kdePackages.discover.debug
  • kdePackages.discover.dev
  • kdePackages.discover.devtools
  • libsForQt5.discover
  • libsForQt5.kinfocenter
  • pantheon.elementary-greeter
  • pantheon.elementary-onboarding
  • pantheon.elementary-settings-daemon
  • pantheon.switchboard-plug-about
  • pantheon.switchboard-plug-pantheon-shell
  • pantheon.switchboard-plug-power
  • pantheon.switchboard-plug-security-privacy
  • pantheon.switchboard-with-plugs
  • pantheon.wingpanel-applications-menu
  • pantheon.wingpanel-indicator-power
  • pantheon.wingpanel-quick-settings
  • pantheon.wingpanel-with-indicators

x86_64-darwin

aarch64-darwin

@ofborg ofborg bot requested a review from r-vdp September 25, 2024 10:27
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Sep 25, 2024
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Sep 25, 2024
@r-vdp
Copy link
Contributor

r-vdp commented Sep 25, 2024

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@r-vdp merge not permitted (#305350):
pr author is not in restricted authors list, in the list are: r-ryantm

@GaetanLepage GaetanLepage merged commit eb191b2 into NixOS:master Sep 25, 2024
38 of 39 checks passed
@GaetanLepage GaetanLepage deleted the fwupd branch September 25, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-vdp r-vdp Awaiting requested review from r-vdp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GaetanLepage @r-vdp @wegank